Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually use the offset in CompressedFPSource #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmohrhard
Copy link
Contributor

No description provided.

@esc
Copy link
Member

esc commented Jul 30, 2020

@mmohrhard hi and welcome to bloscpack. Thank you very much for your contribution and your efforts to improve bloscpack. I just had a look at the CI system and noticed, that the project has been dormant for some time. Hence the tests are not in good shape, they are testing older versions of Python and probably the APIs of the Numpy dependency have changed. This means, it is a bit tricky to work out why the tests are failing. I think it would be a good idea to improve the state of the test suite first before attempting to merge this fix.

@esc
Copy link
Member

esc commented Aug 7, 2020

Hey, I fixed master, can you rebase this and force push please?

@mmohrhard mmohrhard force-pushed the fix-offset-in-compressedfpsource branch from 9a86dde to 2d707f4 Compare August 10, 2020 20:04
@mmohrhard
Copy link
Contributor Author

I have pushed an updated patch but found one place where the current code is a bit ugly. I'm not too fond of the change in bloscpack/cli.py but it seems that there can be files without an offset header.

@mmohrhard mmohrhard force-pushed the fix-offset-in-compressedfpsource branch from 2d707f4 to a6636de Compare August 11, 2020 00:39
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 95.397% when pulling a6636de on mmohrhard:fix-offset-in-compressedfpsource into 2c0086b on Blosc:master.

@esc
Copy link
Member

esc commented Aug 11, 2020

From what I recall, it is possible to disable offsets in a file with the settings:

https://github.com/blosc/bloscpack#settings

This was done, in case people wanted smaller files with less over head but without the additional features that offsets enables.

@esc
Copy link
Member

esc commented Aug 11, 2020

@mmohrhard thanks very much for contributing this, I have added it to the queue for review.

@esc
Copy link
Member

esc commented Mar 11, 2021

@mmohrhard apologies for the delay, could you rebase this against current master. All CI issues have been fixed there. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants