Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support memoryviews #80

Merged
merged 16 commits into from
May 26, 2015
Merged

Support memoryviews #80

merged 16 commits into from
May 26, 2015

Conversation

esc
Copy link
Member

@esc esc commented Mar 28, 2015

No description provided.

@esc
Copy link
Member Author

esc commented Mar 28, 2015

Let's see what travis says.

@esc
Copy link
Member Author

esc commented Mar 28, 2015

Looks like this has the added benefit of being able to compress (unicode) strings in Py3. 👍

@esc
Copy link
Member Author

esc commented Mar 28, 2015

This still needs quite a lot of work, but should be doable in principle, the code is a proof-of concept.

@esc esc mentioned this pull request Mar 29, 2015
@esc esc force-pushed the vh/feature/memoryview branch 2 times, most recently from e55e6e4 to df99404 Compare May 3, 2015 18:18
@esc esc force-pushed the vh/feature/memoryview branch 4 times, most recently from fc8c39c to e9352d0 Compare May 26, 2015 19:55
@esc
Copy link
Member Author

esc commented May 26, 2015

Okay, this one is pretty much ready now. Some notes:

I had to disable Travis-CI for Python 3.2 since it raises Syntax errors on unicode literals.

On Python 2.x we support unicode, on 3.x we don't. This mimics exactly how the zlib module works and actually required some Python version checking in the C module source-code. Not that nice, I know but it works.

Return type is always bytes, like zlib.

For now, it only support compression of bytes-like objects with buffer interface, decompression to be added as a separate pull-request.

@esc esc force-pushed the vh/feature/memoryview branch 2 times, most recently from eb3a5f0 to 7e78b40 Compare May 26, 2015 20:56
@esc
Copy link
Member Author

esc commented May 26, 2015

Not enough maintainers, will merge this by myself.

esc added a commit that referenced this pull request May 26, 2015
@esc esc merged commit 76a1581 into Blosc:master May 26, 2015
@esc esc deleted the vh/feature/memoryview branch May 26, 2015 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant