Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reason the L50 and L50_95 parameters that control maturity at length are not being passed along to the OM properly #50

Closed
tcarruth opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@tcarruth
Copy link

tcarruth commented Nov 8, 2023

In this case the OM is sent to RCMfit with only L50 and L50_95 slots set (50, and 10 respectively).

After RCM fitting, if I plot the OM:

plot(RCMfit@OM)

the maturity at length is more like L50 = 50, L50_95 = 20 (much flatter).

RCMfit.zip

@tcarruth tcarruth added the bug Something isn't working label Nov 8, 2023
@quang-huynh
Copy link
Member

RCM uses SampleStockPars() to grab Mat_age and only passes this array to the conditioned OM, where L50 and L95 are subsequently back-calculated (also by SampleStockPars) but does not recover the original values.

The solution is to copy over the values from the original OM to cpars in the conditioned OM (I believe this is primarily for reporting purposes as the population model uses Mat_age?)

StockPars <- SampleStockPars(OM)
vars <- c('L50array', 'L95array', 'ageMarray', 'age95array')

RCMfit <- RCM(OM, ...)
RCMfit@OM@cpars[vars] <- StockPars[vars]

@tcarruth
Copy link
Author

Well if the plot(fit) is misleading we should fix that. Folks are looking at that and saying the length selectivity curve is too flat when its actually steeper according to Fit@OM@cpars$SLarray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants