-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add synapse spike replay #55
Conversation
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage ? 79.82%
=======================================
Files ? 72
Lines ? 4906
Branches ? 0
=======================================
Hits ? 3916
Misses ? 990
Partials ? 0 |
Thanks for implementing spike replay! This is very useful for us! One question: A great usecase is to "re-run" single cell simulations in the context of a former neurodamus circuit run. I recall the legacy bglibpy had essentially perfect agreement with neurodamus voltage traces. Is this currently the case with BluweCelluLab? We're trying it out now on our end, but can't seem to get it to work. I would seem like the OU process rng seeds are not the same ... Could you offer some insight as to this is a known issue or if its expected to work? Thanks! |
Hi @markovg , happy to hear the spike replay feature will be useful for you and thanks for the feedback.
Yes we are still aiming for having a consistent output with neurodamus. To this end, the CI check called "ci/gitlab/bbpgitlab.epfl.ch" is triggering the scientific tests on our internal cluster. Those are comparing the neurodamus runs with bluecellulab runs to ensure voltage traces agree. There are currently 110 tests and all pass. Those include the 2 OU simulations below.
It may be the case that our tests are not covering your use-case (which is a very useful feedback for us). I would like to ask a few questions to narrow down the possibilities.
|
Changes
Missing feature [implemented]:Node set resolution is missing.node_sets can have aliases"HipProjections": {
"population": "hippocampus_projections"},
our synapse replay works with hippocampus_projections but it cannot realise HipProjections is the same.Results:
Input
The results are from the added
test_add_synapse_replay
BEFORE
AFTER