BRAYNS 440 - Simplify model management #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adrien4193
reviewed
Oct 20, 2022
| @@ -70,49 +41,53 @@ class ModelFinder | |||
| } | |||
|
|
|||
| template<typename Container> | |||
| static auto &findInstance(Container &instances, const uint32_t instanceId) | |||
| static auto &find(Container &instances, uint32_t instanceId) | |||
There was a problem hiding this comment.
I would call that get as it returns a reference and use find when the result can be null.
NadirRoGue
force-pushed
the
BRAYNS-440_simplify_model_manager
branch
from
136a681
to
3bdd807
Compare
Adrien4193
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.