Fixed volume rendering in OSPRay module #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Jul 26, 2017
| intersectionWeights[depth] = 1.f; | ||
| intersectionColors[depth] = make_vec3f(0.f); | ||
| // intersectionWeights[depth] = 1.f; | ||
| // intersectionColors[depth] = make_vec3f(0.f); |
tribal-tec
reviewed
Jul 26, 2017
| } | ||
| } | ||
| t += self->volumeEpsilon; | ||
| } | ||
| if (self->shadows != 0.f && iteration > 0) | ||
| pathColor = pathColor * VOLUME_DEFAULT_ALPHA; | ||
| // if (self->shadows != 0.f && iteration > 0) |
favreau
force-pushed
the
master
branch
2 times, most recently
from
f1855ef
to
f4eb50b
Compare
tribal-tec
reviewed
Jul 28, 2017
| @@ -240,7 +244,8 @@ inline float shadedLightIntensity(const uniform AbstractRenderer* uniform self, | |||
| return intensity; | |||
| } | |||
|
|
|||
| // AABB-Ray intersection ( http://prideout.net/blog/?p=64 ). | |||
| // AABB-Ray intersection ( http://prideot += | |||
| // self->volumeEpsilon;ut.net/blog/?p=64 ). | |||
There was a problem hiding this comment.
Thanks... bad copy paste. Fixed
tribal-tec
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.