Minor cleanups, remove Engine::getParametersManager() #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
approved these changes
Oct 20, 2017
added 8 commits
October 25, 2017 11:33
tribal-tec
reviewed
Oct 25, 2017
brayns/Brayns.cpp
Outdated
| createEngine(); | ||
|
|
||
| #if (BRAYNS_USE_DEFLECT || BRAYNS_USE_NETWORKING) | ||
| // after createEngine() to execue in parallel to scene loading |
| _parametersManager->getRenderingParameters().getEngine(); | ||
| _engine = _engineFactory->get(engineName); | ||
| _parametersManager.getRenderingParameters().getEngine(); | ||
| _engine = _engineFactory.create(engineName); |
There was a problem hiding this comment.
I would still _engine.reset() explicitly, otherwise two engines are active until the assignment to the unique_ptr is done
| delete[] argv; | ||
| return _engines[name]; | ||
| } | ||
| return make_unique<OSPRayEngine>(_argc, _argv, _parametersManager); |
There was a problem hiding this comment.
iirc, the reason for the copy of argv is that engines might mutate it, aka if the engine is not taking a const char*. Please check that, or we have a look together.
There was a problem hiding this comment.
I think that only the LivreEngine had a constness problem, but it is already making a copy of the args internally... I seriously hope that no engine actually alters the CL parameters though!
tribal-tec
suggested changes
Oct 25, 2017
|
argggggg!! |
|
AAAAAARRRRRRRRRRHHHHHHHH
… Le 25 oct. 2017 à 17:27, Raphael Dumusc ***@***.***> a écrit :
argggggg!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
tribal-tec
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.