Added Optix engine #32
Conversation
| # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
| # DEALINGS IN THE SOFTWARE. | ||
| # | ||
| ############################################################################### |
There was a problem hiding this comment.
Needs to go into Acknowledgements.
There was a problem hiding this comment.
Ok, thanks. Still now quite sure how to properly do that. Will ask you tomorrow.
There was a problem hiding this comment.
Removed the files. No ack needed anymore.
| if(BRAYNS_OPTIX_ENABLED) | ||
| common_find_package(OptiX REQUIRED SYSTEM) | ||
| common_find_package(CUDA REQUIRED SYSTEM) | ||
| endif() |
There was a problem hiding this comment.
rm required and activate the engines found, fail if no engine is found.
There was a problem hiding this comment.
Hum... ok, changed because I understand this is what we do everywhere else. But to me, it's not because the dependencies are present that you necessarily want to build the module.
| PointLightPtr sunLight( new PointLight( | ||
| DEFAULT_SUN_POSITION, DEFAULT_SUN_COLOR, DEFAULT_SUN_INTENSITY, DEFAULT_SUN_CUTOFF )); | ||
| scene->addLight( sunLight ); | ||
| } |
There was a problem hiding this comment.
Just curious: Why the difference?
There was a problem hiding this comment.
OptiX does not provide a directional light and was too lazy to implement it, but I have to admit that rendering does look better with a directional light. I guess the right answer to your comment is: Ok, I will implement the directional light in OptiX then ;-) Working on it.
| BRAYNS_INFO << "Loading PDB folder " << folder << std::endl; | ||
| boost::filesystem::directory_iterator endIter; | ||
| if( boost::filesystem::exists( folder ) && | ||
| boost::filesystem::is_directory( folder )) |
There was a problem hiding this comment.
is_directory does not return false if !exists?
There was a problem hiding this comment.
It does, thanks for that.
|
Why have you added the FindCUDA scripts? What's wrong with those that CMake already ships? |
|
I did not find any FindCUDA in CMake Common. Is CommonCUDA.cmake doing the job? |
|
No, no. Not in CMake Common, in you very CMake installation. At least in Ubuntu it comes along. |
|
Ok, thanks for the info. Removed. |
favreau
force-pushed
the
optix
branch
6 times, most recently
from
d710b75
to
7a92d1a
Compare
The OptiX engine can be used by setting the following command line option:
--engine optix
3D Models size is limited to what the GPU can handle.