Logic for adding Topology Viewer as a usecase plugin #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
suggested changes
Feb 26, 2018
| @@ -32,6 +32,8 @@ | |||
|
|
|||
| #include <deflect/SizeHints.h> | |||
|
|
|||
| #include <plugins/extensions/plugins/RocketsPlugin.h> | |||
There was a problem hiding this comment.
Why included, I don't see it being used in this file..?
|
|
||
| ImageGenerator _imageGenerator; | ||
|
|
||
| Timer _timer; | ||
|
|
||
| public: | ||
| std::unique_ptr<JsonRpcServer> _jsonrpcServer; |
There was a problem hiding this comment.
style:
- please keep a single public / protect / private section, in this order
- _ prefix is used by convention for private variables and methods (only)
| @@ -89,11 +89,13 @@ std::string hyphenatedToCamelCase(const std::string& hyphenated) | |||
|
|
|||
| namespace brayns | |||
| { | |||
| RocketsPlugin* RocketsPlugin::_instance{nullptr}; | |||
There was a problem hiding this comment.
global variables are evil! ;-) Please find a cleaner way to pass the RocketsPlugin to whoever needs it.
| inline void registerAction(const std::string& name, | ||
| std::function<void()> action) | ||
| { | ||
| RocketsPlugin::instance()->_jsonrpcServer->connect(name, action); |
There was a problem hiding this comment.
if that's where the instance is needed, then the free functions should be made class functions
karjonas
force-pushed
the
topology_viewer_cmake
branch
from
9a85b5d
to
74af030
Compare
|
I cleared out the rpc-related code from this PR since it is not proper anyway. So now it is only the CMake part to merge. |
favreau
approved these changes
Mar 5, 2018
rdumusc
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CMake finds a folder named TopologyViewer in the usecases directory it will include the plugin. There is also some logic for adding custom rpc callbacks to Rockets plugin. This makes it possible to do custom communication between jupyter and the brayns plugin.