Added keyboard shortcuts management #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Oct 31, 2016
| private: | ||
|
|
||
| virtual void _registerKeyboardShortcuts() final; |
There was a problem hiding this comment.
either virtual or final
| @@ -542,7 +542,7 @@ VolumeHandlerPtr Scene::getVolumeHandler() | |||
| { | |||
| boost::filesystem::path fileExtension = | |||
| dirIter->path( ).extension( ); | |||
| if( fileExtension==".raw" ) | |||
| //if( fileExtension==".raw" ) | |||
There was a problem hiding this comment.
yes, on purpose, cleaned up.
| soma.getMeanRadius() * | ||
| _geometryParameters.getRadiusMultiplier() ); | ||
| soma.getMeanRadius() /* * | ||
| _geometryParameters.getRadiusMultiplier()*/ ); |
| @@ -228,6 +229,10 @@ bool NESTLoader::_load( const float timestamp ) | |||
| BRAYNS_DEBUG << "Loading spikes at timestamp: " << timestamp | |||
| << " (" << start << " ms)" << std::endl; | |||
|
|
|||
|
|
|||
| char filename[1024]; | |||
| sprintf( filename, "/home/favreau/medias/volumes/spikes/10pct/events/spikes_%05d.events", int(timestamp*10) ); | |||
There was a problem hiding this comment.
Oops, not on purpose. Thanks again.
| BRAYNS_INFO << "Closing Deflect stream" << std::endl; | ||
| delete _stream.get(); | ||
| _stream.release(); | ||
| _stream = nullptr; |
There was a problem hiding this comment.
ouch! _stream.reset() should be enough
There was a problem hiding this comment.
I should have read 'smart pointers for dummies'. Fixed.
|
|
||
| bool success = _stream->send(deflectImage); | ||
| // TODO: Big Memory Leak on every send. FIX NEEDED!!!!! | ||
| const bool success = _stream->send( deflectImage ); | ||
| _stream->finishFrame(); |
There was a problem hiding this comment.
also evaluate result of finishFrame(). We typically do result = send() && finish();
favreau
force-pushed
the
master
branch
4 times, most recently
from
c8d921c
to
83fd63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.