-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed volume management #443
Conversation
brayns/Brayns.cpp
Outdated
@@ -47,6 +47,7 @@ | |||
|
|||
#include <brayns/tasks/AddModelTask.h> | |||
|
|||
#include <brayns/pluginapi/ExtensionPlugin.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed?
brayns/Brayns.cpp
Outdated
@@ -193,6 +194,12 @@ struct Brayns::Impl : public PluginAPI | |||
auto& scene = _engine->getScene(); | |||
auto& camera = _engine->getCamera(); | |||
|
|||
if (_parametersManager.isAnyModified() || camera.isModified() || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why moved? the transferfunction.isModified() is not needed if you keep the markModified() in OSPRayScene, no?
@@ -733,6 +733,8 @@ class RocketsPlugin::Impl | |||
{ | |||
auto& params = _parametersManager.getVolumeParameters(); | |||
auto postUpdate = [this](VolumeParameters&) { | |||
// Cleanup existing volume data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm?
@@ -271,68 +270,81 @@ bool OSPRayScene::commitTransferFunctionData() | |||
ospCommit(impl); | |||
} | |||
_transferFunction.resetModified(); | |||
markModified(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above, to me this can stay as it was
No description provided.