Update rapidjson to fix gcc 8 compilation in Docker image #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wondering, is there any reason why rapidjson is not a git submodule as the other dependencies usually are? |
|
I just followed the offical way of using it: https://github.com/Tencent/rapidjson/#installation We can also submodule it, I have no strong opinion on that. I just clones a lot of unnecessary things for a header-only library. |
|
Makes sense. Probably now we can then remove the "-Wno-unknown-warning-option" I had to add in some places to fix clang compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.