Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Model::createMissingMaterials #672

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Removed Model::createMissingMaterials #672

merged 2 commits into from
Jan 24, 2019

Conversation

hernando
Copy link
Contributor

No description provided.

karjonas
karjonas reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@karjonas karjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A commit message should ideally explain why it changes something. What it changes can always be seen in the code.

brayns/engine/Model.cpp Outdated Show resolved Hide resolved
@hernando hernando force-pushed the no_create_missing_materials branch 2 times, most recently from 957bacd to 8a43129 Compare January 24, 2019 09:36
@hernando hernando force-pushed the no_create_missing_materials branch 2 times, most recently from dd02bab to 52d2ed1 Compare January 24, 2019 10:36
@hernando
Copy link
Contributor Author

ping

tribal-tec
tribal-tec reviewed Jan 24, 2019
View reviewed changes
brayns/engine/Model.h Outdated Show resolved Hide resolved
Juan Hernando Vieites added 2 commits January 24, 2019 15:38
Removed Model::createMissingMaterials
de98784 
Model::createMaterial refactored to move to the base class most of
the reference handling and leave to the implementation classes
just the creation of the engine specific type.
Remove MaterialsColorMap::none
790302b 
This value was abused to create assign per section type material colors.
Since this is a detail specific of the CircuitViewer plugin, the logic
has been moved there.
@hernando hernando merged commit 8f26064 into master Jan 24, 2019
@hernando hernando deleted the no_create_missing_materials branch January 24, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karjonas karjonas karjonas left review comments

@tribal-tec tribal-tec tribal-tec approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernando @tribal-tec @karjonas