Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FileDriver(s) #622

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Deprecate FileDriver(s) #622

merged 10 commits into from
Oct 28, 2022

Conversation

matz-e
Copy link
Member

@matz-e matz-e commented Oct 27, 2022

The current FileDriver implementations just inherit from
FileAccessProps, and I think that with further additions to the file
access property lists, it is cleaner to just use FileAccessProps
directly.

The current FileDriver implementations just inherit from
FileAccessProps, and I think that with further additions to the file
access property lists, it is cleaner to just use FileAccessProps
directly.
alkino
alkino previously approved these changes Oct 27, 2022
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this way to do is not straight forward following what is done for other properties!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5d88d87). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #622   +/-   ##
=========================================
  Coverage          ?   79.34%           
=========================================
  Files             ?       65           
  Lines             ?     3534           
  Branches          ?        0           
=========================================
  Hits              ?     2804           
  Misses            ?      730           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roblatham00
Copy link
Contributor

roblatham00 commented Oct 27, 2022

Could you also update parallel_hdf5_write_dataset.cpp to demonstrate the preferred method? Sounds like with this change it would simply be

// open a new file with the MPI IO driver for parallel Read/Write
File file(FILE_NAME,
    File::ReadWrite | File::Create | File::Truncate,
    FileAccessProps(MPI_COMM_WORLD, MPI_INFO_NULL));

But there is no FileAccessProps constructor that takes a comm and info

@alkino
Copy link
Member

alkino commented Oct 28, 2022

@roblatham00: I updated the example so you can see.

@1uc
Copy link
Collaborator

1uc commented Oct 28, 2022

There's 3 more occurrences of FileDriver in tests_high_five_base.cpp and one more in tests_high_five_parallel.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants