-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate FileDriver(s) #622
Conversation
The current FileDriver implementations just inherit from FileAccessProps, and I think that with further additions to the file access property lists, it is cleaner to just use FileAccessProps directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 this way to do is not straight forward following what is done for other properties!
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=========================================
Coverage ? 79.34%
=========================================
Files ? 65
Lines ? 3534
Branches ? 0
=========================================
Hits ? 2804
Misses ? 730
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Could you also update // open a new file with the MPI IO driver for parallel Read/Write
File file(FILE_NAME,
File::ReadWrite | File::Create | File::Truncate,
FileAccessProps(MPI_COMM_WORLD, MPI_INFO_NULL)); But there is no FileAccessProps constructor that takes a |
@roblatham00: I updated the example so you can see. |
There's 3 more occurrences of |
The current FileDriver implementations just inherit from
FileAccessProps, and I think that with further additions to the file
access property lists, it is cleaner to just use FileAccessProps
directly.