Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Use simulation widget from MonsteerQt library #168

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

jafyvilla
Copy link
Contributor

Coming from BlueBrain/Monsteer#6

@bilgili
Copy link
Contributor

bilgili commented Oct 20, 2015

I think we can and we should. Bu we can discuss tomorrow.

* @param hostname Hostname to connect.
* @param port Port of the host to connect.
* @return True if connection is successful.
* @param hostname the hostname to connect to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The articles :)

@jafyvilla jafyvilla changed the title Use simulation widget from MonsteerGUI library Use simulation widget from MonsteerQt library Oct 20, 2015
@rdumusc
Copy link

rdumusc commented Oct 21, 2015

don't forget to git rm stimuliController/

@jafyvilla
Copy link
Contributor Author

Thanks! I didn't notice it was still there...

@@ -222,23 +217,21 @@ struct StimuliController::Impl
public:

::monsteer::Simulator* _simulator;
zeq::Subscriber* _selectionSubscriber;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::unique_ptr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole stimuliController will be gone, I'll amend the commit with the sha1 from BlueBrain/Monsteer#6 once it's merged

@tribal-tec
Copy link
Contributor

+1 otherwise

jafyvilla pushed a commit that referenced this pull request Oct 23, 2015
Use simulation widget from MonsteerQt library
@jafyvilla jafyvilla merged commit a32cb3e into BlueBrain:master Oct 23, 2015
@jafyvilla jafyvilla deleted the use_monsteergui branch October 23, 2015 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants