This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Use simulation widget from MonsteerQt library #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can and we should. Bu we can discuss tomorrow. |
* @param hostname Hostname to connect. | ||
* @param port Port of the host to connect. | ||
* @return True if connection is successful. | ||
* @param hostname the hostname to connect to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The articles :)
jafyvilla
force-pushed
the
use_monsteergui
branch
from
October 20, 2015 14:26
230bb0d
to
23501ca
Compare
jafyvilla
changed the title
Use simulation widget from MonsteerGUI library
Use simulation widget from MonsteerQt library
Oct 20, 2015
jafyvilla
force-pushed
the
use_monsteergui
branch
from
October 20, 2015 15:25
23501ca
to
0ff7317
Compare
don't forget to git rm stimuliController/ |
Thanks! I didn't notice it was still there... |
@@ -222,23 +217,21 @@ struct StimuliController::Impl | |||
public: | |||
|
|||
::monsteer::Simulator* _simulator; | |||
zeq::Subscriber* _selectionSubscriber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::unique_ptr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole stimuliController will be gone, I'll amend the commit with the sha1 from BlueBrain/Monsteer#6 once it's merged
+1 otherwise |
jafyvilla
force-pushed
the
use_monsteergui
branch
from
October 23, 2015 12:19
0ff7317
to
ae99dd7
Compare
jafyvilla
pushed a commit
that referenced
this pull request
Oct 23, 2015
Use simulation widget from MonsteerQt library
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from BlueBrain/Monsteer#6