This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Fix #225. Adapted shader alpha correction to the minimum number of sa… #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,8 @@ namespace livre | |||
|
|
|||
| #define glewGetContext() GLContext::glewGetContext() | |||
|
|
|||
| const uint32_t nDefaultSamplesPerRay = 512; | |||
There was a problem hiding this comment.
const static or move into anon namespace
bilgili
force-pushed
the
alpha_correction
branch
from
cc19ae9
to
f05a892
Compare
|
please retest this |
|
Retest this please. |
bilgili
force-pushed
the
alpha_correction
branch
3 times, most recently
from
3a24fe6
to
1cbb78b
Compare
|
Do not merge it yet ! We have to check the alpha correction value is meaningful. @chevtche will check for it. |
bilgili
force-pushed
the
alpha_correction
branch
from
46a48da
to
585ca74
Compare
bilgili
force-pushed
the
alpha_correction
branch
from
585ca74
to
44d0b36
Compare
|
@eile - ping |
|
+1 |
bilgili
pushed a commit
that referenced
this pull request
Feb 8, 2016
Fix #225. Adapted shader alpha correction to the minimum number of sa…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mples