Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Move setup of data- & textureUploadProcessor to Window #34

Merged
merged 1 commit into from
Jun 5, 2015
Merged

Move setup of data- & textureUploadProcessor to Window #34

merged 1 commit into from
Jun 5, 2015

Conversation

tribal-tec
Copy link
Contributor

No description provided.

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/47/
Test FAILed.

@tribal-tec
Copy link
Contributor Author

retest this please

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/48/
Test PASSed.


void configExitGL()
{
if( !_dashProcessorPtr.unique( ))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should use texture- or dataUploadProcessor here. dashProcessor is not reset() in exit of window....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

* thread start from Pipe and context setup from Channel now grouped in Window
* shared windows also share the processors
* resolves LIV-193:
  * fixes racy setup with most of the data
  * fixes crash with multiple local GPUs
  * fixes crash at exit
@tribal-tec
Copy link
Contributor Author

Updated

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/49/
Test PASSed.

bilgili pushed a commit that referenced this pull request Jun 5, 2015
Move setup of data- & textureUploadProcessor to Window
@bilgili bilgili merged commit 11eef22 into BlueBrain:master Jun 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants