Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Fix missing redraw after expose #352

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Conversation

eile
Copy link
Contributor

@eile eile commented Dec 2, 2016

No description provided.

@@ -274,6 +274,13 @@ template< class C > void EventHandler< C >::init()
}

template< class C >
bool EventHandler< C >::handleEvent( eq::EventType, const eq::Event& )
{
_impl->config.postRedraw();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about Equalizer event processing, but shouldn't there be a check that this actually is an "expose event" if this is what this commit is fixing? Otherwise, it looks like this is going to trigger postRedraw more often than before. If you think this is fine, then I trust your expertise :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are events handled here, and I think all should redraw:
case EVENT_WINDOW_CLOSE:
case EVENT_WINDOW_HIDE:
case EVENT_WINDOW_EXPOSE:
case EVENT_EXIT:
case EVENT_WINDOW_POINTER_GRAB:
case EVENT_WINDOW_POINTER_UNGRAB:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even those like CLOSE / HIDE / EXIT ? I would probably have listed made a white-list, but as long as this has no adverse side effect then I guess it's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@tribal-tec tribal-tec merged commit 9f0d6e7 into BlueBrain:master Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants