This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Fix 16-bits and anisotropic raw volumes bugs #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
suggested changes
Dec 21, 2016
rdumusc
reviewed
Dec 21, 2016
| @@ -81,15 +75,13 @@ class NoMemoryUnit : public MemoryUnit | |||
| class ConstMemoryUnit : public MemoryUnit | |||
| { | |||
| public: | |||
| ConstMemoryUnit( const uint8_t* ptr, const size_t size ); | |||
| explicit ConstMemoryUnit( const uint8_t* ptr ); | |||
There was a problem hiding this comment.
How is this possible that the size is unused? With a raw pointer you always need a size, the only exception I know of is the '\0' terminated c_str, but no such convention seems to be used / documented here...
There was a problem hiding this comment.
So as per our discussion, the whole MemoryUnit classes should be rewritten, but this is a bigger story. Meanwhile, this "cleanup" is OK as it highlights the underlying design issues.
| @@ -253,6 +233,50 @@ struct RayCastRenderer::Impl | |||
| _computedSamplesPerRay = std::max( maxVoxelsAtLOD, (float)minSamplesPerRay ); | |||
| } | |||
|
|
|||
| Vector2f dataSourceRange; | |||
| uint32_t shaderDataType; | |||
| switch( _dataSource.getVolumeInfo().dataType ) | |||
There was a problem hiding this comment.
this switch is too long to be inlined and should be moved back to one or two separate methods.
rdumusc
approved these changes
Dec 21, 2016
tribal-tec
approved these changes
Dec 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.