Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SomaC center #231

Closed
mgeplf opened this issue Jan 20, 2016 · 10 comments
Closed

SomaC center #231

mgeplf opened this issue Jan 20, 2016 · 10 comments

Comments

@mgeplf
Copy link
Collaborator

mgeplf commented Jan 20, 2016

Hello,
The documentation states:

    Type C: multiple points soma
    Represented by a contour.
    Reference: neuromorpho.org
    The first point constitutes the center of the soma,
    '''

But I'm having problems confirming that the first point is the center of the soma on neuromorpho.org, could you please provide a pointer to this?

@juanchopanza
Copy link
Contributor

I can't find it either. I found this:

Soma can be a single point or more than one point. When the soma is encoded as one line in the SWC, it is interpreted as a "sphere". When it is encoded by more than 1 line, it could be a set of tapering cylinders (as in some pyramidal cells) or even a 2D projected contour ("circumference").

@lidakanari could you comment on this?

@lidakanari
Copy link
Contributor

I used this definition: http://neuromorpho.org/neuroMorpho/SomaFormat.html which apparently has been removed!!!

@juanchopanza
Copy link
Contributor

We can remove the reference to neuromorpho and say this is how we interpret a multiple point soma, in the absence of any means to know what it is supposed to represent. We could also think of some heuristics to guess what three or more points represent.

@lidakanari
Copy link
Contributor

So we should define the three types of soma by ourselves? (That seems like the only solution in the absence of a meaningful definition in the web).

@lidakanari
Copy link
Contributor

Update: new location found!

http://neuromorpho.org/SomaFormat.html

"The first point constitutes the center of the soma, with coordinates (xs, ys, zs) corresponding to the average of all the points in the single contour. "

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jan 20, 2016

Cool, thanks for finding that. I read the quoted string as saying that the soma center should be the average of the contour points, which is also how the h5 calculates it. Right now, I don't think that is happening: it's just picking the first point and assuming it's the center which means the soma.center property is confusing.

@lidakanari
Copy link
Contributor

It assumes that the first point contains those info. We definitely have to look into this and probably confirm it! I'd like to add this as a proper function but I'm still waiting for a concrete format for the soma structures.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jan 21, 2016

I think I fixed it here: #233

Also, I think it would be a good idea to name the soma classes more descriptively:
SomaA -> SomaSinglePoint
SomaB -> SomaThreePoint
SomaC -> SomaContour

@juanchopanza
Copy link
Contributor

Fixed in #233.

@lidakanari
Copy link
Contributor

I completely agree with @mgeplf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants