Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort principal direction extents in descending order #1017

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Sort principal direction extents in descending order #1017

merged 1 commit into from
Apr 1, 2022

Conversation

eleftherioszisis
Copy link
Contributor

Sorts principal_direction_extents feature so that direction=0 corresponds to the biggest and direction=2 to the smallest extent.

Closes #1009

@eleftherioszisis eleftherioszisis self-assigned this Apr 1, 2022
@eleftherioszisis eleftherioszisis merged commit ed518c4 into master Apr 1, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/sorted-principal-directions branch April 1, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudon arnaudon arnaudon approved these changes

@adrien-berchet adrien-berchet adrien-berchet approved these changes

@lidakanari lidakanari Awaiting requested review from lidakanari

Assignees

@eleftherioszisis eleftherioszisis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximal direction extent
3 participants
@eleftherioszisis @adrien-berchet @arnaudon