Fix strahler.swc #769
Merged
Fix strahler.swc #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a first point at the root node in order not to start with a bifurcation. Because starting with a bifurcation in SWC is broken (but fixed in morphio)
mgeplf
reviewed
Oct 2, 2019
| @@ -4,22 +4,23 @@ | |||
| # https://commons.wikimedia.org/wiki/File:Flussordnung_(Strahler).svg | |||
|
|
|||
There was a problem hiding this comment.
can you add a comment that describes that there is now a difference from the link above?
There was a problem hiding this comment.
You mean, with the strahler orders represented in the pictures ?
Because they haven't changed. Actually, if I am not mistaken, the file is now more morphologically correct than it used to be because on the picture the branch is not starting with a bifurcation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a first point at the root node in order not to start with a bifurcation.
Because starting with a bifurcation in SWC is broken (but fixed in morphio)
The test was passing, but a bit by luck.