Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example astrocyte analysis notebook #959

Merged
merged 5 commits into from Sep 3, 2021
Merged

Update example astrocyte analysis notebook #959

merged 5 commits into from Sep 3, 2021

Conversation

pgetta
Copy link
Contributor

@pgetta pgetta commented Sep 3, 2021

  • Make the notebook work with the latest NeuroM
  • Add astrocyte selection and download from NGV static server
  • Make figures larger

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #959 (4516c75) into master (830cd7d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2136      2136           
=========================================
  Hits          2136      2136           

@pgetta pgetta changed the title Update example astrocyte analysis notebook WIP: Update example astrocyte analysis notebook Sep 3, 2021
@pgetta pgetta changed the title WIP: Update example astrocyte analysis notebook Update example astrocyte analysis notebook Sep 3, 2021
@asanin-epfl
Copy link
Contributor

you can use plotly if you want plots to be nicer, scalable, manipulable by user.

@pgetta
Copy link
Contributor Author

pgetta commented Sep 3, 2021

That would be really nice, do you have by any chance an example how this can be done?

@asanin-epfl
Copy link
Contributor

a neighbor tutorial getting_started.ipynb contains examples of plotly graphics in the beginning.

@asanin-epfl
Copy link
Contributor

Also would be good to rename Neuron id to Astrocyte id in "Morphology Analysis" paragraph.

@pgetta
Copy link
Contributor Author

pgetta commented Sep 3, 2021

Thank you, Aleksei,
Indeed, plotly works better for this case, I've also renamed neuron to astrocyte in the morphology analysis paragraph.

Anything else of concern?

Copy link
Contributor

@asanin-epfl asanin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, everything should be fine by now

@pgetta pgetta merged commit 52a38e4 into BlueBrain:master Sep 3, 2021
@pgetta
Copy link
Contributor Author

pgetta commented Sep 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants