fix raw option in morph_stat #964
Conversation
|
I'm adding the raw key in test for coverage |
|
@asanin-epfl , why not .tolist? |
|
@arnaudon and why .tolist ? |
|
We are waiting for @arnaudon coverage tests on 'raw' mode. |
|
here you are |
tests/apps/test_morph_stats.py
Outdated
| } | ||
| } | ||
|
|
||
| REF_OUT = { | ||
| 'morphology': { | ||
| 'mean_soma_radius': 0.13065629648763766, | ||
| 'mean_max_radial_distance': 99.5894610648815, | ||
| 'raw_max_radial_distance': 99.5894610648815, |
There was a problem hiding this comment.
so, raw_max_radial_distance and mean_max_radial_distance are the same? is it ok?
There was a problem hiding this comment.
there is just one number here
There was a problem hiding this comment.
we can put raw in another entry if we want, but it may yield many numbers
|
I don't know how to fix coverage... |
|
ok, I will fix the coverage |
This reverts commit 1f260b3
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2136 2138 +2
=========================================
+ Hits 2136 2138 +2 |
|
Thank you! |
| @@ -233,12 +241,16 @@ def test_extract_dataframe_multiproc(): | |||
| for name in ['Neuron.swc', 'simple.swc']] | |||
| with warnings.catch_warnings(record=True) as w: | |||
| actual = ms.extract_dataframe(morphs, REF_CONFIG, n_workers=2) | |||
| # drop raw features as they require too much test data to mock | |||
There was a problem hiding this comment.
@adrien-berchet please confirm whether you are ok with such approach. I use in in 4 places here.
There was a problem hiding this comment.
yes, it's fine, we don't care about the numbers, this is tested elsewhere
|
do you need a release? |
|
no, it's fine! I just noticed when I was trying something locally, don't bother! |
When
rawoption is used, it crashed becausenp.rawdoes not exist.