Add trunk_angles_inter_types feature and make trunk_angles more generic #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
7148d45
to
771fb21
Compare
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2233 2216 -17
=========================================
- Hits 2233 2216 -17 |
asanin-epfl
reviewed
Sep 20, 2021
asanin-epfl
reviewed
Sep 20, 2021
|
One last minor note and lgtm for me. |
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
a899c29
to
8e7bc6d
Compare
|
Should we wait for Alexis or Lida? |
Yes it would be better as they will be the main users of this feature. |
|
@adrien-berchet please don't forget to rebase |
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
8e7bc6d
to
2f3763a
Compare
arnaudon
approved these changes
Sep 21, 2021
asanin-epfl
reviewed
Sep 23, 2021
asanin-epfl
approved these changes
Sep 23, 2021
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
295500e
to
db8e38f
Compare
|
@pgetta I add you as reviewer because I don't know who is in charge of this repo now that @asanin-epfl is away? |
|
Hi Adrien, |
arnaudon
approved these changes
Oct 4, 2021
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
cd0d1c4
to
d4ff728
Compare
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
d4ff728
to
32f85e3
Compare
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
af6c936
to
51550e5
Compare
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
51550e5
to
f8307ec
Compare
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
f8307ec
to
e1f44fb
Compare
…more consistent with standard
adrien-berchet
force-pushed
the
trunk_3d_angles_feature
branch
from
e1f44fb
to
ff6863e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.