Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use soma center in sholl_frequency distance calculation #989

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Use soma center in sholl_frequency distance calculation #989

merged 3 commits into from
Feb 25, 2022

Conversation

eleftherioszisis
Copy link
Contributor

Fixes #988

@mgeplf
Copy link
Collaborator

mgeplf commented Feb 25, 2022

Nice catch

@mgeplf
Copy link
Collaborator

mgeplf commented Feb 25, 2022

Would it be worth adding a test where the soma isn't at the origin?

@eleftherioszisis
Copy link
Contributor Author

Would it be worth adding a test where the soma isn't at the origin?

Yes, good point. I added one.

@eleftherioszisis eleftherioszisis merged commit b6c3beb into master Feb 25, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/fix-sholl-frequency-center branch February 25, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeplf mgeplf mgeplf approved these changes

@adrien-berchet adrien-berchet Awaiting requested review from adrien-berchet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sholl_frequency does not use soma center to calculate max radius
2 participants
@eleftherioszisis @mgeplf