Fix sholl_frequency for NA neurite_type
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2332 2334 +2
=========================================
+ Hits 2332 2334 +2 |
adrien-berchet
approved these changes
Feb 28, 2022
|
Good point. I added this case in the |
|
LGTM! |
eleftherioszisis
deleted the
zisis/fix-sholl-frequency-NA-neurite_type
branch
mgeplf
reviewed
Mar 1, 2022
| @@ -3,10 +3,18 @@ Changelog | |||
|
|
|||
| Version 3.2.0 | |||
| ------------- | |||
| - Fix ``neurom.features.morphology.sholl_frequency`` to return an empty list when a | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
sholl_frequencyreturns an empty list for aneurite_typethat is not present in the morphology.Fixes #987