This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
add ner k8s #643
Open
drsantos89
wants to merge
36
commits into
master
Choose a base branch
from
feature/k8s_ner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add ner k8s #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 26, 2022
EmilieDel
reviewed
Oct 27, 2022
…into feature/k8s_ner
…into feature/k8s_ner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a function to perform and store the output of NER.
NER is run remotely using the deployment on Kubernetes. It supports both ML and RULE-based approaches.
The NER output and model version are stored in ES.
Notes
handle_conflits
, is currently found in two repositories (this current PR and one repo on GitLab). It might be interesting to keep it only inBlueSearch
and import it into the other repository.locust
revealed a maximum possible performant of ~15 and ~50 for ML and RULE models, respectively. A multiprocessing option was hence added.client
object is not serializable and needs to be called inside the function if required.flattened
. ("This data type can be useful for indexing objects with a large or unknown number of unique keys. Only one field mapping is created for the whole JSON object, which can help prevent a [mappings explosion (https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html#mapping-limit-settings) from having too many distinct field mappings.")How to test?
tests/unit/k8s/test_ner.py
Checklist
(if needed)
(if a function is added or modified)