Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify window interaction [DISCL-320] #28

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

rdumusc
Copy link

@rdumusc rdumusc commented May 27, 2016

No description provided.

Simplify window interaction [DISCL-320].
This change makes interacting with contents more natural and intuitive:
- No differences between windows in presentation mode vs. regular mode
- A glow effect highligts windows which have the focus (capture touch events).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'highligts'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tribal-tec
Copy link
Contributor

+1 otherwise. I'd like to see a demo!

@rdumusc
Copy link
Author

rdumusc commented May 30, 2016

no problem for the demo, let me know when you have time!

@rdumusc rdumusc force-pushed the interaction branch 2 times, most recently from 726b3b7 to 5c73cdc Compare May 31, 2016 12:51
@rdumusc
Copy link
Author

rdumusc commented May 31, 2016

Updated with slightly more coverage + fixes for initial size for large contents + changes to resize handles as discussed this morning

@rdumusc
Copy link
Author

rdumusc commented May 31, 2016

Last details addressed, I'm ready to merge when Jenkins builds again. The next PR for the fullscreen mode is ready too :-)

@rdumusc
Copy link
Author

rdumusc commented Jun 1, 2016

retest this please

@rdumusc rdumusc merged commit b9c3f1f into BlueBrain:master Jun 1, 2016
@rdumusc rdumusc deleted the interaction branch June 1, 2016 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants