Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility for ultraliser v0.4.0 #9

Closed
wants to merge 1 commit into from

Conversation

asoplata
Copy link
Contributor

This makes the necessary changes for placement-hints' mesh creation to use the current version of Ultraliser, v0.4.0

@asoplata
Copy link
Contributor Author

I tried beginning to run the tests, and unfortunately updating the tests for ultraliser v0.4.0 will likely be a significant pain: it seems the tests are hardcoded to use ultraliser v0.1.0 ( https://github.com/BlueBrain/atlas-placement-hints/blob/main/tests/distances/test_create_watertight_mesh.py#L19 ), and I know for a fact that ultraliser has gone through breaking changes across its versions.

@asoplata
Copy link
Contributor Author

The tests begin to fail when transitioning from ultraliser v0.3.0 (available in archive/2022-05, among others) to ultraliser v0.4.0. Simply changing the location of the executable causes the tests to fail. One cause of this is almost certainly because the filenames/formats that ultraVolume2Mesh expects seem to have changed when moving to v0.4.0, which is part of what I had to change in the commit in this PR.

@asoplata
Copy link
Contributor Author

Don't worry about this PR for now -- see #11 (comment)

@arnaudon
Copy link
Contributor

I've done it in #18

@arnaudon
Copy link
Contributor

arnaudon commented Feb 1, 2024

I guess we can close this one then?

@mgeplf
Copy link
Collaborator

mgeplf commented Feb 2, 2024

yup, fine on my end, @asoplata?

@asoplata
Copy link
Contributor Author

asoplata commented Feb 5, 2024

Sure

@asoplata asoplata closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants