Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split C++ code in 2 separate shared libraries #32

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Split C++ code in 2 separate shared libraries #32

merged 2 commits into from
Jan 21, 2019

Commits on Jan 21, 2019

  1. Split C++ code in 2 separate shared libraries 

    Remove `Basalt_BUILD_PYTHON_PACKAGE` CMake option to choose if
the pure C++ library has to be built or the Python bindings.

Now CMake builds 2 shared libraries:
* `basalt` which contain pure C++ code.
* `_basalt`: built by pybind11, and depends on the first.
  a dirty workaround is required in `basalt/__init__.py` so that
  Python bindings can find the pure C++ code at runtime.

Only build Python bindings during `python setup.py build` to
prevent including the pure C++ shared library in Python package.
    Tristan Carel committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    827116f View commit details
    Browse the repository at this point in the history

  2. Fix clang-tidy execution 

    Configuring CMake so that it creates a JSON file with command line of
every translation unit at cmake time. Then this file is given to clang-format
so that it has all include directories.
    Tristan Carel committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    6e57971 View commit details
    Browse the repository at this point in the history