added numerics and conditions to call numerics component to search #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M3 #1013 +/- ##
===========================================
Coverage ? 65.95%
===========================================
Files ? 21
Lines ? 611
Branches ? 126
===========================================
Hits ? 403
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
…en the trgger is execited fro the es query
dhaneshnm
approved these changes
Jan 6, 2022
nicwells
reviewed
Jan 6, 2022
There was a problem hiding this comment.
- Show missing values doesn't appear to be working for me, seems to have no effect and doesn't disable other controls (related to next point)
- Clicking on column dropdown arrow results in filter being applied immediately and missing values being removed from results
- between filter looks a little strange and seems to be repeated (see screenshot below)
- Couple of styling comments: when numbers is over a certain size it doesn't fit in text box, right side of slider is a bit close to max text box, would be nice to format number of missing values to include comma separator
- Crashes for me when opening the filter for Bouton Density when pointing to dev - not sure if this is a data thing or not
…en the trgger is execited fro the es query
…to 2938-nums * '2938-nums' of https://github.com/BlueBrain/nexus-web: 2986 fix styles (#1015) Add redirect params to login call back (#1014) 2644 allow user to select search config (#1011) Rewrite useLocalStorage hook and make use of (#1012)
* refactor login, date, num , filter
dhaneshnm
approved these changes
Jan 10, 2022
nicwells
reviewed
Jan 10, 2022
nicwells
approved these changes
Jan 10, 2022
dhaneshnm
added a commit
that referenced
this pull request
Mar 11, 2022
…1013) * added numeric and conditions to call numeric component to search Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch> Co-authored-by: Dhanesh Neela Mana <dhanesh.n.m19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Added the numerics filter logic but since all the fields with numerics are actually returning strings it is not convenient to test. I have added some preliminary logic to convert the data to actual integers.
The logic for the min, max for the slider range is there too. As well as the show missing checkbox condition but the logic connecting it to the missing query is not added.
How has this been tested?
Types of changes
Checklist: