Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen for CVODE #1493

Merged
merged 103 commits into from
Oct 31, 2024
Merged

Codegen for CVODE #1493

merged 103 commits into from
Oct 31, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Oct 2, 2024 •
edited
Loading

Actual codegen for CVODE. Requires #1467 (done), #1483 (done), #1484 (done)

@JCGoran
Add DerivativeOriginalFunctionBlock and DerivativeVisitor
417acac
@JCGoran
Remove unused functions
d33a594
@JCGoran
Add test for DerivativeOriginalVisitor
b9f08d0
@JCGoran
Fmt
c5dc45e
@JCGoran
Fix leak
1dadd7a
@JCGoran
Remove unused stuff
1125fdf 
`DERIVATIVE` blocks can't have array variables in NOCMODL by default, so
let's go with that.
@JCGoran
Update block description
0267fbd
@JCGoran
Rename DERIVATIVE_ORIGINAL to CVODE
e58070f
@JCGoran
Finish renaming
044dfd9
@JCGoran
Add item with Jacobian
50f38ce
@JCGoran
Merge branch 'master' into jelic/cvode_visitors
bc68701
@JCGoran
Do not use an int but an enum-wrapped int
f82fe1f
@JCGoran
Add support for diffing expressions with indexed vars
bd2fd36
@JCGoran
Allow diffing implicit functions in differentiate2c
b082f0d 
Uses finite differences
@JCGoran
Simplify condition
edf33a7
@JCGoran
Better testing
565fa03
@JCGoran
Add suggestions from code review
6bd6aed
@JCGoran
Add stepsize param to differentiate2c
0eba407
@JCGoran
Merge remote-tracking branch 'origin/master' into jelic/diff_implicit
405909e
@JCGoran
Try Python 3.9 maybe?
c1e7fd3
@JCGoran
Merge branch 'jelic/diff_indexed' into jelic/cvode_visitors
0207373
@JCGoran
Merge branch 'jelic/diff_implicit' into jelic/cvode_visitors
32d36a8
@JCGoran
Add codegen
4562945
@JCGoran JCGoran added the NEURON codegen Work toward NEURON code generation label Oct 2, 2024
1uc
1uc reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! In terms of testing I suspect POINT_PROCESS and ARTIFICIAL_CELL might both behave in special ways, you can either include them now or fix them in separate PRs.

src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
test/usecases/cvode/test_cvode.py Outdated Show resolved Hide resolved
test/usecases/cvode/derivative.mod Show resolved Hide resolved
@JCGoran JCGoran mentioned this pull request Oct 28, 2024
Closed
2 tasks
1uc
1uc approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

src/codegen/codegen_neuron_cpp_visitor.hpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.hpp Outdated Show resolved Hide resolved
@JCGoran JCGoran merged commit 3df34b9 into master Oct 31, 2024
12 checks passed
@JCGoran JCGoran deleted the jelic/cvode_codegen_only branch October 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees
No one assigned
Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCGoran @1uc