Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for async execution of OpenACC and OpenMP #788

Closed
wants to merge 3 commits into from

Conversation

iomaganaris
Copy link
Contributor

Follows changes from BlueBrain/CoreNeuron#725

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30131 (:white_check_mark:) have been uploaded here!

Status and direct links:

Base automatically changed from hackathon_main to master December 22, 2021 16:59
}


void CodegenAccVisitor::print_device_stream_wait() const {
printer->add_line("#pragma acc wait(nt->stream_id)");
printer->start_block("if(nt->compute_gpu)");
printer->add_line("nrn_pragma_acc(wait async(nt->streams[nt->stream_id]))");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iomaganaris / @olupton: doesacc wait async(stream_id) change any execution semantics here compared to previous acc wait (stream_id) ?

from what I read in the nvforum - “wait async” is used to create dependencies between different async queues. So if your parallel regions had different queue numbers, you add “wait(Q1) async(Q2)” where Q2 should wait for Q1 to finish before running.

@codecov-commenter
Copy link

Codecov Report

Merging #788 (ada8638) into master (d2e7295) will not change coverage.
The diff coverage is 0.00%.

❗ Current head ada8638 differs from pull request most recent head afd70c5. Consider uploading reports for the commit afd70c5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files         208      208           
  Lines       29969    29969           
=======================================
  Hits        18441    18441           
  Misses      11528    11528           
Impacted Files Coverage Δ
src/codegen/codegen_acc_visitor.cpp 0.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e7295...afd70c5. Read the comment docs.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30401 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc
Copy link
Collaborator

1uc commented Mar 27, 2024

Timed out.

@1uc 1uc closed this Mar 27, 2024
@1uc 1uc deleted the magkanar/async branch July 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants