-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for async execution of OpenACC and OpenMP #788
Conversation
Logfiles from GitLab pipeline #30131 (:white_check_mark:) have been uploaded here! Status and direct links: |
} | ||
|
||
|
||
void CodegenAccVisitor::print_device_stream_wait() const { | ||
printer->add_line("#pragma acc wait(nt->stream_id)"); | ||
printer->start_block("if(nt->compute_gpu)"); | ||
printer->add_line("nrn_pragma_acc(wait async(nt->streams[nt->stream_id]))"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iomaganaris / @olupton: doesacc wait async(stream_id)
change any execution semantics here compared to previous acc wait (stream_id)
?
from what I read in the nvforum - “wait async” is used to create dependencies between different async queues. So if your parallel regions had different queue numbers, you add “wait(Q1) async(Q2)” where Q2 should wait for Q1 to finish before running.
8355747
to
afd70c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 61.53% 61.53%
=======================================
Files 208 208
Lines 29969 29969
=======================================
Hits 18441 18441
Misses 11528 11528
Continue to review full report at Codecov.
|
Logfiles from GitLab pipeline #30401 (:white_check_mark:) have been uploaded here! Status and direct links: |
Timed out. |
Follows changes from BlueBrain/CoreNeuron#725