Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with debug printing of visitors #854

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

iomaganaris
Copy link
Contributor

After the refactoring of the codegen configuration the intermediate files being generated with nmodl_ast option were not printed properly with the correct name.
This PR prints them with the proper name and in the correct place.
Same for json_ast and json_perfstat.

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have two questions/comments.

src/pybind/pynmodl.cpp Outdated Show resolved Hide resolved
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #51802 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk merged commit 64e8cee into llvm Apr 29, 2022
@pramodk pramodk deleted the magkanar/fix_nmodl_ast branch April 29, 2022 19:19
iomaganaris added a commit that referenced this pull request May 10, 2022
* Fixes issue with debug printing of the various stages of code generation in files
* Small fix and comment addition
iomaganaris added a commit that referenced this pull request May 12, 2022
* Fixes issue with debug printing of the various stages of code generation in files
* Small fix and comment addition
iomaganaris added a commit that referenced this pull request Sep 15, 2022
* Fixes issue with debug printing of the various stages of code generation in files
* Small fix and comment addition
iomaganaris added a commit that referenced this pull request Sep 15, 2022
* Fixes issue with debug printing of the various stages of code generation in files
* Small fix and comment addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants