[LLVM][FIX] Float generation fix in LLVM helper visitor #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logfiles from GitLab pipeline #54237 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
reviewed
May 12, 2022
|
Logfiles from GitLab pipeline #54405 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
approved these changes
May 12, 2022
pramodk
approved these changes
May 12, 2022
iomaganaris
force-pushed
the
georgemitenkov/float-fix
branch
from
b27645b
to
68c80ef
Compare
|
Logfiles from GitLab pipeline #54550 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Fixed float AST in helper * Fixed InstanceStruct test to generate struct with doubles
iomaganaris
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Fixed float AST in helper * Fixed InstanceStruct test to generate struct with doubles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how single-precision floats are handles in LLVM
helper visitor. Before,
DOUBLEwas always created which wasnot consistent with LLVM visitor (that lowered
DOUBLEto 32-or 64-bit types) and instance struct initialisation in testing (which
assumed that for
DOUBLEit always holds thatsizeof(double) = 8).Now, there is a clear separation between
FLOATandDOUBLEvalues in helper visitor.
Note: this bug was not discovered before since execution tests were
only considering doubles. So, one of the tests was changed to use
floats.