Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] Fixes compilation with LLVM codegen disabled #867

Merged
merged 2 commits into from
May 19, 2022
Merged

[LLVM] Fixes compilation with LLVM codegen disabled #867

merged 2 commits into from
May 19, 2022

Conversation

iomaganaris
Copy link
Contributor

@iomaganaris iomaganaris commented May 13, 2022 •
edited
Loading

  • Makes sure that llvm branch compiles with LLVM codegen and Python bindings disabled or enabled
  • Selectively enables options of Python Codegen and Python JIT Driver
  • Fixes the order of linkage of static variables for the generation of nmodl binary

@iomaganaris iomaganaris changed the title Fixes compilation with LLVM codegen disabled [LLVM] Fixes compilation with LLVM codegen disabled May 13, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #54804 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk
pramodk approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pybind/pynmodl.cpp Show resolved Hide resolved
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #55599 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit da3078c into llvm May 19, 2022
@iomaganaris iomaganaris deleted the magkanar/fix_non_llvm branch May 19, 2022 12:24
iomaganaris added a commit that referenced this pull request Sep 15, 2022
@iomaganaris
[LLVM] Fixes compilation with LLVM codegen disabled (#867)
ac48c5e 
* Makes sure that llvm branch compiles with LLVM codegen and Python bindings disabled or enabled
* Only compile benchmark folder when LLVM backend is enabled
* Selectively enables options of Python Codegen and Python JIT Driver based on LLVM backend being enabled or disabled
* Fixes the order of linkage of static variables for the generation of nmodl binary
iomaganaris added a commit that referenced this pull request Sep 15, 2022
@iomaganaris
[LLVM] Fixes compilation with LLVM codegen disabled (#867)
253f639 
* Makes sure that llvm branch compiles with LLVM codegen and Python bindings disabled or enabled
* Only compile benchmark folder when LLVM backend is enabled
* Selectively enables options of Python Codegen and Python JIT Driver based on LLVM backend being enabled or disabled
* Fixes the order of linkage of static variables for the generation of nmodl binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@ohm314 ohm314 Awaiting requested review from ohm314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iomaganaris @bbpbuildbot @pramodk