Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM] Instantiate CodegenLLVMVisitor of PyJIT with fast math and debug symbols options #912

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

iomaganaris
Copy link
Contributor

  • Set add_debug_information and fast_math_flags variables when constructing the CodegenLLVMVisitor of the PyJIT Driver according to the variables passed to the python object of CodeGenConfig
  • Added related test

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #70564 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #70567 (:white_check_mark:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #70609 (:white_check_mark:) have been uploaded here!

Status and direct links:

@ohm314 ohm314 merged commit c161879 into llvm Aug 24, 2022
@ohm314 ohm314 deleted the magkanar/pyjit_llvm_visitor branch August 24, 2022 07:18
iomaganaris added a commit that referenced this pull request Sep 15, 2022
…ug symbols options (#912)

* Added options for fast math and debug symbols on CodegenLLVMVisitor instantiated by NMODL PyJIT
* Disable debug symbols in GPU PyJIT test

Co-authored-by: Ioannis Magkanaris <ioannis.magkanaris@epfl.ch>
iomaganaris added a commit that referenced this pull request Sep 15, 2022
…ug symbols options (#912)

* Added options for fast math and debug symbols on CodegenLLVMVisitor instantiated by NMODL PyJIT
* Disable debug symbols in GPU PyJIT test

Co-authored-by: Ioannis Magkanaris <ioannis.magkanaris@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants