Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getting morphology directory public in MorphHelper #258

Merged
merged 1 commit into from Feb 14, 2024

Conversation

joni-herttuainen
Copy link
Contributor

also rename: _get_morph_dir -> get_morphology_directory

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a12630) 100.00% compared to head (6a0b042) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2706      2706           
=========================================
  Hits          2706      2706           
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joni-herttuainen joni-herttuainen merged commit 4a64964 into master Feb 14, 2024
4 checks passed
@joni-herttuainen joni-herttuainen deleted the nsetm_2290 branch February 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants