Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmodl: testing variant to unbreak the tests #2441

Merged
merged 6 commits into from
May 21, 2024
Merged

nmodl: testing variant to unbreak the tests #2441

merged 6 commits into from
May 21, 2024

Conversation

heerener
Copy link
Collaborator

#2440 breaks the nmodl tests because they use pytest. Let's add a variant so we can install those optional dependencies when testing.

Maybe packages should depends on other packages that they use after all
(with a variant if necessary)
@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd bring this in line with NEURON:

var/spack/repos/builtin/packages/neuron/package.py
34:    variant("tests", default=False, description="Enable building tests")

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick (I promise): line 100 build_testing should then be define_from_variant, too :)

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.1.0
  • neurodamus-mousify/1.6-3.2.1-2.8.1
  • neurodamus-neocortex-plasticity/2.1.0
  • neurodamus-neocortex/2.1.0
  • neurodamus-thalamus/2.1.0
  • neuron/9.0.a16
  • psp-validation/0.5.0
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.2.9
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3

matz-e
matz-e previously approved these changes May 17, 2024
@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.1.0
  • neurodamus-mousify/1.6-3.2.1-2.8.1
  • neurodamus-neocortex-plasticity/2.1.0
  • neurodamus-neocortex/2.1.0
  • neurodamus-thalamus/2.1.0
  • neuron/9.0.a16
  • psp-validation/0.5.0
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.2.9
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.1.0
  • neurodamus-mousify/1.6-3.2.1-2.8.1
  • neurodamus-neocortex-plasticity/2.1.0
  • neurodamus-neocortex/2.1.0
  • neurodamus-thalamus/2.1.0
  • neuron/9.0.a16
  • psp-validation/0.5.0
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.2.9
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.1.0
  • neurodamus-mousify/1.6-3.2.1-2.8.1
  • neurodamus-neocortex-plasticity/2.1.0
  • neurodamus-neocortex/2.1.0
  • neurodamus-thalamus/2.1.0
  • neuron/9.0.a16
  • psp-validation/0.5.0
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.2.9
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3

@JCGoran JCGoran merged commit d63de27 into develop May 21, 2024
12 checks passed
@JCGoran JCGoran deleted the nmodl-pytest branch May 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants