-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmodl: testing variant to unbreak the tests #2441
Conversation
Maybe packages should depends on other packages that they use after all (with a variant if necessary)
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd bring this in line with NEURON:
var/spack/repos/builtin/packages/neuron/package.py
34: variant("tests", default=False, description="Enable building tests")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpick (I promise): line 100 build_testing should then be define_from_variant
, too :)
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable Please test the following updated modules:
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable Please test the following updated modules:
|
The following build jobs of the deployment for this PR failed:
Please fix the following packages that failed to build: |
The following build jobs of the deployment for this PR failed:
Please fix the following packages that failed to build: |
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable Please test the following updated modules:
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2441/config/modules.sh
module load unstable Please test the following updated modules:
|
#2440 breaks the nmodl tests because they use pytest. Let's add a variant so we can install those optional dependencies when testing.