attempt to load middleware listed in the config that may be in node m… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the service loader cannot find the middleware, an error will be thrown and the server start will fail. This does not differ from the previous behavior because an error would have been thrown by initConsumers() if it got to that point. |
|
Looks good, but let's also add a test case to protect us from future regression. |
seanpk
reviewed
Nov 8, 2016
| }); | ||
| }); | ||
|
|
||
| describe.only('SERVER11 - middleware should get loaded from node modules', function () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odules
Tested by listing a node module in the middleware config. That module was loaded properly. Anything that was already loaded in the bootstrapping process will be unaffected.