Add support for CORS origins defined by regular expressions #99
Conversation
Currently, the config is defined in a JSON file. Therefore, all entries to the cors.origins array must be strings. However, the cors npm package used in blueoak-server supports regular expressions as cors origins. In order to utilize that functionality, this PR converts any string in the origin array into a RegExp if it starts with a leading slash.
There was a problem hiding this comment.
Why not use the inline RegExp format for this?
i.e. keying off the string starting with /:
/.+\.foobar\.net/
Generally, there are many options that can be passed to the cors middleware that can't be expressed in JSON.
What if we provide support such that if config.get('cors') is a string instead of an object, that we treat it as a file path and try to require it and use it as the options parameter?
Tests are required.
| // Convert any CORS origin defined with regex (i.e. starts with '^') | ||
| // from JSON string into an actual RegExp object. | ||
| for (var i = 0; i < cfg.origin.length; i++) { | ||
| if (cfg.origin[i].startsWith('^')) { |
There was a problem hiding this comment.
String.prototype.startsWith is not supported by older versions of node.js which BOS supports
|
In the case the led to the PR, the project switched to using a |
Currently, the config is defined in a JSON file. Therefore, all entries to the
cors.originsarray must be strings. However, the CORS npm package used in blueoak-server supports regular expressions as CORS origins. In order to utilize that functionality, this PR converts any string in the origin array into a RegExp if it starts with^.