Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep history #4

Closed
smaragdus opened this issue Jan 25, 2020 · 10 comments
Closed

Keep history #4

smaragdus opened this issue Jan 25, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@smaragdus
Copy link

I would like to suggest an option for saving download history- perhaps new check box in settings:

  • Keep history

which, when enabled, would save download history to file.

For me an option to keep log of downloaded files would be useful.

@alxnull alxnull added the enhancement New feature or request label Jan 25, 2020
@alxnull
Copy link
Member

alxnull commented Mar 22, 2020

This has been added in v.0.2.0 (using the download archive feature included in youtube-dl).

@alxnull alxnull closed this as completed Mar 22, 2020
@smaragdus
Copy link
Author

@alxnull

I could not test 'Use Download Archive' feature because for me version 0.2.0.0 simply does not work. It can fetch the video, screen:

Vividl 0 2 0 0 - 2020-03-23 - error - 001

but the download never initiates, screen:

Vividl 0 2 0 0 - 2020-03-23 - error - 002

I tried different videos with different youtube-dl versions, the downloads never started.

However version 0.1.1.0 works just fine, it fetches videos, screen:

Vividl 0 1 1 0 - 2020-03-23 - 006

and downloads them just right, screen:

Vividl 0 1 1 0 - 2020-03-23 - 007

Are you sure that version 0.2.0.0 is not faulty?

@alxnull
Copy link
Member

alxnull commented Mar 23, 2020

Sorry to hear that. Unfortunately, I'm currently not able to reproduce this behaviour using either the portable or the installer version, on Windows 10 and on Windows 7. Does this happen only if you check the "Use Download Archive" option or always? Does this happen only for some videos or for all?

P.S.: I disabled update checking temporarily for everyone.

@smaragdus
Copy link
Author

@alxnull

I did a new test with new settings and I think that I can shed some light about the problem.

If I use:

Default download format: Convert to MP4, screen:

Vividl 0 2 0 0 - 2020-03-25 - 001

the download starts and finishes successfully, screen:

Vividl 0 2 0 0 - 2020-03-25 - 002

But If I choose:

Default download format: Best Download, screens:

Vividl 0 2 0 0 - 2020-03-25 - 003

Vividl 0 2 0 0 - 2020-03-25 - 005

or if I select another format from the drop-down menu, screens:

Vividl 0 2 0 0 - 2020-03-25 - 004

Vividl 0 2 0 0 - 2020-03-25 - 006

download fails. But if I revert to Convert to MP4, the download starts and finishes just right, screen:

Vividl 0 2 0 0 - 2020-03-25 - 008

In short- in my tests when Convert to MP4 is enabled, all downloads always complete fine, but when I switch to Best Download or any other format, all downloads always fail. It seems that manually choosing a format causes the downloads to fail. Can you confirm that?

About Use Download Archive feature, screen:

Vividl 0 2 0 0 - 2020-03-25 - 010

file .archive.txt was saved not in program folder (I am using the portable version of Vividl) but on Desktop (my default download folder). Moving file .archive.txt has no effect, it is always saved on Desktop. I think that .archive.txt should be saved in program folder (next to executable- Vividl.exe) for portable version and in AppData for installer version. What do you think?

@alxnull
Copy link
Member

alxnull commented Mar 25, 2020

In short- in my tests when Convert to MP4 is enabled, all downloads always complete fine, but when I switch to Best Download or any other format, all downloads always fail. It seems that manually choosing a format causes the downloads to fail. Can you confirm that?

I was able to reproduce this issue now. If I'm right, the failure happens for the "Best Download" option and all formats that are shown additionally when "Show all available formats" is enabled in the settings. Does this match with your observations?

I've already found the cause for this bug and I'm in the process of fixing it. Thanks again for your patience and your efforts in finding and reporting this issue, really appreciate that. Would you mind testing the application to confirm that the issue is resolved also on your side before I release a new update? (I would provide you a pre-release binary for testing.)

file .archive.txt was saved not in program folder (I am using the portable version of Vividl) but on Desktop (my default download folder). Moving file .archive.txt has no effect, it is always saved on Desktop. I think that .archive.txt should be saved in program folder (next to executable- Vividl.exe) for portable version and in AppData for installer version. What do you think?

Currently, the archive is kept on a per-folder basis, so this behaviour was intended. However, I'm open to change this as I'm thinking of replacing the archive feature provided by youtube-dl with something own anyway.

@smaragdus
Copy link
Author

@alxnull

I was able to reproduce this issue now. If I'm right, the failure happens for the "Best Download" option and all formats that are shown additionally when "Show all available formats" is enabled in the settings. Does this match with your observations?

Yes, this is exactly what I found out to be causing the failed downloads. I think this bug must have been introduced in version 0.2.0.0 as I don't encounter it in version 0.1.1.0.

I've already found the cause for this bug and I'm in the process of fixing it. Thanks again for your patience and your efforts in finding and reporting this issue, really appreciate that. Would you mind testing the application to confirm that the issue is resolved also on your side before I release a new update? (I would provide you a pre-release binary for testing.)

I really like Vividl and I would be glad to be able to contribute a bit to its development with doing some tests. If there are any pre-releases feel free to upload them and I will do some testing (if everything is normal- within 48 hours).

Currently, the archive is kept on a per-folder basis, so this behaviour was intended.

I see,

However, I'm open to change this as I'm thinking of replacing the archive feature provided by youtube-dl with something own anyway.

I think that it might be better if the program uses and keeps its own list of downloaded videos in its own format which would mean that the list of previously downloaded videos would be persistent and would not be lost after the program is closed and restarted (if the feature to keep download list is enabled).

Regards

@alxnull
Copy link
Member

alxnull commented Mar 26, 2020

I think this bug must have been introduced in version 0.2.0.0 as I don't encounter it in version 0.1.1.0.

You're right, this bug is new to version 0.2.0.

I really like Vividl and I would be glad to be able to contribute a bit to its development with doing some tests. If there are any pre-releases feel free to upload them and I will do some testing.

I've uploaded a binary for testing (portable version only) at https://vividl.sourceforge.io/vividl-pre-releases/Vividl-v.0.2.1-Portable.zip. This version should have fixed the download issues you reported and added an additionaly checkbox in the settings that disables automatic update checking. (I haven't changed anything for the download history yet). Would be great if you could test this binary to check whether all issues are removed. Thanks!

@smaragdus
Copy link
Author

@alxnull

I downloaded and tested the version you provided. I downloaded 9 videos using different settings and all the videos were downloaded successfully. However I noticed something else- when I manually selected best MP4 resolution:

  • mp4 - 137 - 1920x1080 (1080p)

screen:

Vividl 0 2 1 - 2020-03-26 - 001

The video was downloaded without audio. Can you confirm this?

In short, it seems that version 0.2.1 fixed the problem introduced in version 0.2.0. Also, thank you for adding a check-box for:

Automatically check for updates at startup

screen:

Vividl 0 2 1 - 2020-03-26 - 002

It is fine update check to be on by default but it is nice to be able to disable it (in circumstances like this one when there is a problem with the latest version).

Thank you for the quick fix!

If you don't encounter other problems you may close this issue.

I will do more tests and if I notice a problem I will report it.

@alxnull
Copy link
Member

alxnull commented Mar 26, 2020

Thank you very much for the testing. I just published the new version (v.0.2.1) containing the fixes.

The video was downloaded without audio. Can you confirm this?

Yes, I can confirm this. The additional download formats are downloaded as provided by the websites. YouTube seems to provide this specific format as a video only format.

@smaragdus
Copy link
Author

@alxnull

Thanks for releasing version 0.2.1.

@alxnull alxnull closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants