Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set disconnected_callback in the constructor for newer bleak compat #49

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 26, 2022

Bleak now wants the disconnected_callback in the constructor

need to update aiohomekit as well
Sep 26 05:03:12 homeassistant homeassistant[485]: TypeError: AIOHomeKitBleakClient.__init__() got an unexpected keyword argument 'disconnected_callback'

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 84.87% // Head: 84.74% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (1aa3067) compared to base (238b1f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   84.87%   84.74%   -0.13%     
==========================================
  Files           2        2              
  Lines         238      236       -2     
  Branches       55       54       -1     
==========================================
- Hits          202      200       -2     
  Misses         30       30              
  Partials        6        6              
Impacted Files Coverage Δ
src/bleak_retry_connector/__init__.py 87.55% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as draft September 26, 2022 05:03
@bdraco bdraco marked this pull request as ready for review September 26, 2022 16:49
@bdraco bdraco merged commit e2e25b3 into main Sep 26, 2022
@bdraco bdraco deleted the disconnected_callback branch September 26, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants