Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust connect timeout to match macos write timeout #66

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 6, 2022

The timeout was not long enough to connect to some of the slower older devices

The timeout was not long enough to connect to some of the slower
older devices
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 85.57% // Head: 85.57% // No change to project coverage 👍

Coverage data is based on head (9aa797f) compared to base (702a829).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files           2        2           
  Lines         298      298           
  Branches       73       73           
=======================================
  Hits          255      255           
  Misses         30       30           
  Partials       13       13           
Impacted Files Coverage Δ
src/bleak_retry_connector/__init__.py 87.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit 1396fdc into main Nov 6, 2022
@bdraco bdraco deleted the esp_adjust branch November 6, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant