fix: increase backoff when local ble adapter runs out of connection slots #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.57% // Head: 85.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 85.57% 85.38% -0.19%
==========================================
Files 2 2
Lines 298 301 +3
Branches 73 74 +1
==========================================
+ Hits 255 257 +2
- Misses 30 31 +1
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
added a commit
to sblibs/pySwitchbot
that referenced
this pull request
Nov 11, 2022
In Bluetooth-Devices/bleak-retry-connector#67 we discovered that most of the CSR adapters only have 5 connection slots so we want to reduce the chance we will not be able to make a connection because we are still holding the connection to another switchbot. We still hold the connection for 8.5 seconds every time they do an action to ensure if they want to turn on a light and change a color the whole action happens in a single connection.
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing it was found that most of the CSR adapters only support 5 slots and the broadcom only support 7 slots.
When they run out of slots the device they are trying to connect to disappears from the bus so we must backoff