Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop trying to check dbus once the socket is missing #70

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 30, 2022

Each call to get_device would try over and over to connect to dbus when the socket is missing. This is normal when dbus is not setup and only using bluetooth proxies
fixes #69

Each call to get_device would try over and over to connect
to dbus when the socket is missing. This is normal when
dbus is not setup and only using bluetooth proxies
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 85.38% // Head: 85.71% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (78acbbf) compared to base (09cb73d).
Patch coverage: 87.50% of modified lines in pull request are covered.

❗ Current head 78acbbf differs from pull request most recent head 6137eb5. Consider uploading reports for the commit 6137eb5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.38%   85.71%   +0.33%     
==========================================
  Files           2        2              
  Lines         301      308       +7     
  Branches       74       76       +2     
==========================================
+ Hits          257      264       +7     
+ Misses         31       30       -1     
- Partials       13       14       +1     
Impacted Files Coverage Δ
src/bleak_retry_connector/__init__.py 87.88% <87.50%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit 74bd63b into main Nov 30, 2022
@bdraco bdraco deleted the handle_missing_dbus branch November 30, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't keep trying to init bluez if dbus is missing
1 participant