fix: avoid logging connecting and connected since our BLEDevice may be stale #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stale Since we can get a new BLEDevice after we call connect, we should not log the adapter as it may be stale. The logging should happen in HA instead.
Codecov ReportBase: 85.71% // Head: 83.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 85.71% 83.81% -1.90%
==========================================
Files 2 2
Lines 308 309 +1
Branches 76 76
==========================================
- Hits 264 259 -5
- Misses 30 34 +4
- Partials 14 16 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can get a new BLEDevice after we call connect, we should not log the adapter as it may be stale.
The logging should happen in HA instead.