Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this library in both pre and post ICS #5

Closed
naddaf opened this issue Sep 14, 2012 · 3 comments
Closed

Using this library in both pre and post ICS #5

naddaf opened this issue Sep 14, 2012 · 3 comments

Comments

@naddaf
Copy link

naddaf commented Sep 14, 2012

Hi.

My project should run on 2.3.3+ devices, all the way up to and including JB. I have added your library to get the nice looking Switch control and it works nicely. The only issue I have is that on my JB device, the look of the Switch is not quite right; the "thumb" is a rectangle instead of having slanted sides; it is perfectly functional but on 2.3.3, it looks like the standard ICS Switch but on post ICS, it doesn't.

How should I do the theme so that it works nicely on pre and post ICS?

Thanks for writing this library,
Ali.

@intrications
Copy link
Contributor

The look of switch changed to this rectangular look in JB.

However, if you want to use the slanted look in all versions of Android then delete the res/drawable-*-v16 folders.

@naddaf
Copy link
Author

naddaf commented Sep 14, 2012

Many thanks.
Ali

@naddaf naddaf closed this as completed Sep 14, 2012
@BoD
Copy link
Owner

BoD commented Sep 14, 2012

Hi!

Actually this is the wanted behavior.
They changed the resources of the thumb in JB to be rectangular. You can
verify that for instance in the system settings app. So this library will
use the 'old' resources for < 4.1 and the 'new' ones (rectangular) for >=
4.1.

BoD
On Sep 14, 2012 10:59 PM, "naddaf" notifications@github.com wrote:

Hi.

My project should run on 2.3.3+ devices, all the way up to and including
JB. I have added your library to get the nice looking Switch control and it
works nicely. The only issue I have is that on my JB device, the look of
the Switch is not quite right; the "thumb" is a rectangle instead of having
slanted sides; it is perfectly functional but on 2.3.3, it looks like the
standard ICS Switch but on post ICS, it doesn't.

How should I do the theme so that it works nicely on pre and post ICS?

Thanks for writing this library,
Ali.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants