Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support multiple variants #215

Closed
patalex74 opened this issue Nov 11, 2020 · 3 comments · Fixed by #217
Closed

[FR] Support multiple variants #215

patalex74 opened this issue Nov 11, 2020 · 3 comments · Fixed by #217

Comments

@patalex74
Copy link

Lors de la recherche de "venait" seul la 3ème personne de l'indicatif du verbe "vener" est retourné, alors que dans le wiktionary les 2 sens sont bien indiqués.

Patalex

@lasconic
Copy link
Collaborator

lasconic commented Nov 11, 2020

Indeed, it's a known limitation. Currently we use one of the two verb forms. I thought it was the first one in the article, but apparently it's the first one alphabetically.

In order to get both, we could extend the variant in Word to an array, but then I'm not sure how Kobo would react if "venait" becomes a variant of both "venir" and "vener"

@lasconic lasconic changed the title Homonymie entre la 3ème personne des verbes "venir" et "vener" [FR] "Venait" only redirected to "vener" and not "venir" Nov 11, 2020
@BoboTiG
Copy link
Owner

BoboTiG commented Nov 11, 2020

@lasconic could you try multiple variants for that word to check how Kobo will behave? I hope it will display both verbs 🤞 🤞 :)

@lasconic
Copy link
Collaborator

lasconic commented Nov 11, 2020

@lasconic could you try multiple variants for that word to check how Kobo will behave? I hope it will display both verbs 🤞 🤞 :)

Yes it works. That's the easy case... since "venir" and "vener" both have the same 2 letters prefix...

Then we have the less easy cases...

  • suis -> être / suivre
  • ailles -> aller / ailler
  • pûmes -> pouvoir / paître
  • ...

In this case, I will list "suis" twice in the "su.html" file... Once with the definitions of être and one with the definition of suivre...

@lasconic lasconic changed the title [FR] "Venait" only redirected to "vener" and not "venir" [FR] 'Venait' only redirected to 'vener' and not 'venir' Nov 11, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 11, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 11, 2020
@BoboTiG BoboTiG changed the title [FR] 'Venait' only redirected to 'vener' and not 'venir' [FR] Support multiple variants Nov 11, 2020
lasconic added a commit to lasconic/ebook-reader-dict that referenced this issue Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants